search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

Values missing from GetActivityHistory for Mayhem #596

Open ykslebutv opened 6 years ago

ykslebutv commented 6 years ago

Mayhem that just started today is causing PGCR calls to hang.

I can do some curls later and provide examples, but I checked this on a couple of users - once you have played a Mayhem game, your PGCRs will not return data.

UPDATE: after some debugging, looks like the issue is that data returned by the Destiny2.GetActivityHistory endpoint is missing team and standing values for Mayhem games.

ckhicks commented 6 years ago

Can I quickly call "first" on recognizing the insane irony of mayhem working as designed? 😆

vthornheart-bng commented 6 years ago

Yeah, if you get a chance, send over a user that you're seeing this happen on and we can take a look!

vthornheart-bng commented 6 years ago

I've not been able to repro this yet. If you're seeing specific PGCRs experiencing this issue, hit me up with a PGCR ID

vthornheart-bng commented 6 years ago

Just to note, we are definitely seeing Mayhem activities coming down as an improper activity mode ("AllPvP") and are investigating that further. I don't see any evidence of unusual timeouts or hanging on our side in the logs however. If you find someone experiencing these symptoms, hit me up!

ykslebutv commented 6 years ago

@vthornheart-bng I did some debugging and must apologize - the issue is not as dramatic as I made it sound. There's no hanging or timeouts in API responses, but some data is missing from Mayhem activity history results. Imperfect exception handling in my application made it look as if responses weren't coming in.

The actual issue is that data returned by the Destiny2.GetActivityHistory endpoint is missing team and standing values for Mayhem games.

ykslebutv commented 6 years ago

Updated the title and the first comment.

vthornheart-bng commented 6 years ago

No worries, and good info - I appreciate it! Indeed, it's stemming from a regression in the bug that was causing Mayhem to return as AllPvp before. We're hoping to have a hotfix for that, though I don't have an ETA yet. I also don't know what the fate will be of the existing PGCRs that got processed as AllPvp.

ykslebutv commented 6 years ago

thanks for the update

vthornheart-bng commented 6 years ago

No prob, and thank you for the info!