search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

Supremacy stats not available #66

Closed bladefist closed 6 years ago

bladefist commented 7 years ago

According to the manifest it's mode 40. But mode 40 is tower. I can't find any mode for Supremacy.

Also: AllPvP > control + countdown + survival. I think they should be same.

vthornheart-bng commented 7 years ago

Hmm, where are you seeing that? What area of the manifest is referring to Supremacy?

bladefist commented 7 years ago

@vthornheart-bng It's not in there. But it's active in-game.

Also, if someone were to download every match played (I would never) they would see supremacy isn't showing up. So it's not something we can query because it doesn't have a mode enum. But it is aggregated in AllPvP for ActivityStats.

v-fedorov commented 7 years ago

Here to confirm, these are the only modes I am seeing

'0' '2' '3' '6' '10' '16' '17' '37' '38' '40'

vthornheart-bng commented 7 years ago

Oh - just to clarify, you're saying Destiny 1 has Supremacy active, but it's not defined in Destiny 2 Manifest? Or is it missing in the Destiny 1 manifest?

bladefist commented 7 years ago

@vthornheart-bng I edited my response, I realized I was being super confusing.

vthornheart-bng commented 7 years ago

Hmm, hang tight. I'll ask the stats folks about this.

vthornheart-bng commented 7 years ago

Ah, just got the word back, that was quick - there was a miscommunication on my part, this should have been in the API but isn't. I'll file a bug for us to get it re-added!

v-fedorov commented 7 years ago

Also, supremacy and clash matches are being mislabeled as mode 0. ex: Platform/Destiny2/stats/postgamecarnagereport/66236/

the activityHash is for Javelin-4 with mode being 0

vthornheart-bng commented 7 years ago

Probably the same root cause, but I'll investigate that while I'm fixing this issue!

vthornheart-bng commented 6 years ago

I'm pretty confident that we've found and are fixing the root cause for this. It's being triaged and final testing going through as we speak, should be able to deploy later this week if that goes well.