Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

Rumble win/loss #820

Open ghost opened 5 years ago

ghost commented 5 years ago

Hi @vthornheart-bng ! Can you clarify rumble win/loss api logic?

Based on update 2.0.0.1 "Earning a place in the Top 3 in Rumble will now count as a win", but in api response only 1st place counts as win. As result this may be confused when player was 2nd/3rd and saw in-game win, but on 3rd party services he will see that all matches were loss.

Thanks!

floatingatoll commented 5 years ago

It says “Defeat” in-game when you aren’t first place, IIRC, so this may not just be a confusion in the API?

On Dec 16, 2018, at 08:41, Karandashek notifications@github.com wrote:

Hi @vthornheart-bng ! Can you clarify rumble win/loss api logic?

Based on update 2.0.0.1 "Earning a place in the Top 3 in Rumble will now count as a win", but in api response only 1st place counts as win. As result this may be confused when player was 2nd/3rd and saw in-game win, but on 3rd party services he will see that all matches were loss.

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

ghost commented 5 years ago

Do you mean "Earning a place in the Top 3 in Rumble will now count as a win" applies only for Valor rank points?

floatingatoll commented 5 years ago

I believe that’s how it was intended, though I’m unsure not bring Bungie :/

On Dec 16, 2018, at 10:01, Karandashek notifications@github.com wrote:

Do you mean "Earning a place in the Top 3 in Rumble will now count as a win" applies only for Valor rank points?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

ghost commented 5 years ago

ok, got it :) Thanks!

floatingatoll commented 5 years ago

TWAB 8/16, though the wording is a bit unclear:

A top 3 finish in Rumble will be counted as a win with the associate Valor rank points attached.

On Dec 16, 2018, at 10:31, Karandashek notifications@github.com wrote:

ok, got it :) Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

vthornheart-bng commented 5 years ago

Hmm, I'll have to ask around about this - admittedly it's the first I've heard about it!