search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

Mod description inconsistent with other item types #855

Open josh-h-90 opened 5 years ago

josh-h-90 commented 5 years ago

This was mooted in #83 but closed before it was reviewed.

At the moment, if you want to display Banshee's mods alongside other vendor items, they require a secondary lookup in the manifest to the DestinySandboxPerkDefinition table based on the perks field.

Further complicating this is the logic as to whether you need to perform this lookup is pretty nebulous. Mods are itemType 19, itemSubType 0. So are Ghost Projections, Emotes, Radiances and Transmat Effects. None of these need a second lookup to get their description.

I've found a couple of workarounds - using the itemTypeDisplayName field or the itemCategoryHashes array - but it would be a lot simpler if API could return the description in the displayProperties object like it does for the other item types.

vthornheart-bng commented 5 years ago

Hmm, I dig that - it's definitely an area where I don't like how many gaps we have in strings. Interesting story, in D1 we used to pull Talent Grid data and attempt to associate it with sandbox perks to populate their almost-always-empty strings. But we never had the time to do that for the various places where sandbox perks can be sourced now in D2.

I think it'd be worthwhile if we could find time - but I must forewarn that we're severely understaffed on the API, so I don't know when we'll be able to get to it. But I would like to see us get to it, because the hoops people have to jump through to get human readable strings can be frustrating.

Choppra commented 4 years ago

@vthornheart-bng any progress on this are is there still a staffing issue?