search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

Custom font replacement for [...] to [replacement] isn't being done in zh-* #973

Open floatingatoll opened 5 years ago

floatingatoll commented 5 years ago

Hi, the custom substitution you're doing API-side for e.g. #642 appears not to be applied to locale zh-cht, at least in json/zh-cht/guid-guid-guid-guid-aggregate.json.

delphiactual commented 5 years ago

zh-* are being replaced with unicode characters

https://github.com/delphiactual/d2-additional-info/commit/cfa18b9e806e0799ff71ea2bfe9912d75994d537#diff-0889b7934422e61a857524b12230f0adR334

floatingatoll commented 5 years ago

So, originally, they were Unicode characters, but then the localized text was inserted using the form '[Localized text]' replacing the Unicode characters in the feed (which are invalid in most published fonts — U+E138 is part of the Unicode "private use area").

The resulting U+E138 and similar in the zh-cht data vary from the [Replacement Strings] approach unusually — namely, they don't have the square brackets. Is that an intentional variance?

delphiactual commented 5 years ago

It's like this in both zh-cht and zh-chs and no other languages

https://data.destinysets.com/i/Objective:2062881933

floatingatoll commented 5 years ago

Updated title, thanks

vthornheart-bng commented 5 years ago

Ah, good stuff! TFS: 811430

delphiactual commented 5 years ago

Also should point out there are some typos in the translated strings English: [Rocker Launcher]

and extra spaces for Japanese: [ヘッドショット ] German: [Helmtreffer ]

floatingatoll commented 5 years ago

What’s the correct spelling for German?

On Jul 20, 2019, at 09:43, Rob Jones notifications@github.com wrote:

Also should point out there are some typos in the translated strings English: [Rocker Launcher]

and extra spaces for Japanese: [ヘッドショット ] German: [Helmtreffer ]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

delphiactual commented 5 years ago

extra space at the end... I'll edit to make more clear

vthornheart-bng commented 5 years ago

Ah, thanks, I'll see if we can take a look at those too!