search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

DestinyHistoricalStatsActivity.membershipType is always 0 #978

Open as-com opened 5 years ago

as-com commented 5 years ago

^ title

Here are some PGCR IDs where I have seen this; it appears they are all zero. 4301955761 (cross-save) 4302496725 (Xbox) 4302519473 (PS4) 4302521478 (PC)

vthornheart-bng commented 5 years ago

Thank you for this report, I'll go take a look and file a bug!

vthornheart-bng commented 5 years ago

A heads up for folks who wanted to use this field - a bug has been discovered that may not potentially be fixable in entirety until after Shadowkeep launches. We may be able to get this field to populate correctly in some situations, which I'm still looking into - but unfortunately it is going to be inconsistent without fixes to a deeper system in the Stats infrastructure.

I will keep folks posted once I know more about the timeline for a fix, but this does mean that for Cross Save-inclusive PGCRs created between now and when this bug gets fixed, you will not be able to identify the platform on which they were played.

floatingatoll commented 5 years ago

To confirm, the platform field will either be blank or be correct - but never incorrect?

vthornheart-bng commented 5 years ago

Yes - if you're getting a nonzero value, it'll be the right one. It's just going to be very inconsistent in terms of when you get the right value (and for now, they'll all be zero. I'm working on at least a partial fix that can go out earlier, but it won't be of much use unless the underlying issue is fixed).

mistahj67 commented 5 years ago

I realize it may be too early to tell and you likely don't want to make promises and end up not keeping them. I fully do not hold you to your response one way or another but can you say based on your current knowledge if like previous fixes to game modes that were retroactive to the pgcrs, if this will be retroactive as well where we can plan on correcting the 0 pgcrs once the bug is sufficiently squashed?

vthornheart-bng commented 5 years ago

Unfortunately, the ones that still come through as 0 after I fix the part of the issue that I can fix on the BNet side will remain 0 indefinitely: we won't be able to retroactively fix them. Which is a bummer, and I apologize for any inconvenience that will cause for those of you looking at platform specific information. Unfortunately, the 0's that will stay 0's will be for games played with cross saved accounts, which are the exact ones for whom we'd like to have this information.