As pointed out on #3, media keys aren't working. It's possible that different electron versions handle iframes differently (maybe the ones with no webview tag?), as mine directly redirects to TIDAL web player, leaving no playback control script. From Electron webview docs:
Use the webview tag to embed 'guest' content (such as web pages) in your Electron app. The guest content is contained within the webview container. An embedded page within your app controls how the guest content is laid out and rendered. Unlike an iframe, the webview runs in a separate process than your app.
Now using DBus instead of globalShortcut module since there's an issue that prevents the media keys to be handled more than once. (though it only works on GNOME)
Also since author says it works for him I suppose different setups handle keys differently. I replaced boilerplate package.json infos too, though I know it's not part of this pull request context.
As pointed out on #3, media keys aren't working. It's possible that different electron versions handle iframes differently (maybe the ones with no
webview
tag?), as mine directly redirects to TIDAL web player, leaving no playback control script. From Electron webview docs:Now using DBus instead of
globalShortcut
module since there's an issue that prevents the media keys to be handled more than once. (though it only works on GNOME) Also since author says it works for him I suppose different setups handle keys differently. I replaced boilerplatepackage.json
infos too, though I know it's not part of this pull request context.