search

Bunkerbewohner / tidal-music-linux

An electron based wrapper around the Tidal web player for Linux
MIT License
45 stars 16 forks source link

Update Electron to 0.36.1 and Fix the User-Agent Defines #2

Closed dgadelha closed 8 years ago

dgadelha commented 8 years ago

This will update Electron to ^0.36.1 (it went to 0.36.9 in my case), to support the userAgent feature mentioned at Issue #1 Source Will also fix the code to support the user-agent change

Bunkerbewohner commented 8 years ago

Thanks! Did it actually allow you to play HiFi streams, though? At least for me the option is not available, even with the faked UA. :/

screenshot from 2016-03-03 08 47 05

Bunkerbewohner commented 8 years ago

It seems to me that for HiFi streaming NaCl is required, which is not supported by electron, afaik. See https://github.com/atom/electron/issues/835.

Therefore I'm afraid this PR won't have any actual use apart from bumping the electron version. :(

dgadelha commented 8 years ago

Can you try setting the two variables I suggested under the 'window' context?

Bunkerbewohner commented 8 years ago

I did. I checked out your code and got the results mentioned above. Did it work for you?

dgadelha commented 8 years ago

These ones: https://github.com/Bunkerbewohner/tidal-music-linux/issues/1#issuecomment-191529950