fix: types to support canvas or image ref

Bunlong / next-qrcode

React hooks for generating QRCode for your next React apps.

https://next-qrcode.js.org

MIT License

159 stars 18 forks source link

fix: types to support canvas or image ref #11

Closed jaredscheib closed 3 years ago

jaredscheib commented 3 years ago

Previously the types could not be consumed properly in our application. The return type wanted to be the same as the return type of useRef and accept the generics of either HTMLCanvasElement or HTMLImageElement.

This PR makes that fix so that the proper return type is given, making the TypeScript compiler happy. 🍍

jaredscheib commented 3 years ago

@Bunlong Would you be willing to review this?

Bunlong commented 3 years ago

@jaredscheib I just see it. Okay, I will merge it as soon as possible. I will let you know when it done. Thanks!

jaredscheib commented 3 years ago

Thanks, @Bunlong. I can merge it if it becomes approved after you review it. Thank you again!

jaredscheib commented 3 years ago

Thanks @Bunlong, but actually I'm unable to merge from my end. Likely due to repository permissions. If you'd like to enable that, I'd be happy to merge!

Bunlong commented 3 years ago

@jaredscheib you are invited as collaborator pls confirm.

jaredscheib commented 3 years ago

Done -- thank you, @Bunlong! 🙏🏼 Feel free to remove me as collaborator if you'd like :) ありがとうございました！ 🍍

Bunlong commented 3 years ago

@jaredscheib it's fine. I keep you as collaborator so you can improve it any time. ありがとうございました :bowing_man: