Bunlong / react-papaparse

react-papaparse is the fastest in-browser CSV (or delimited text) parser for React. It is full of useful features such as CSVReader, CSVDownloader, readString, jsonToCSV, readRemoteFile, ... etc.
https://react-papaparse.js.org
MIT License
364 stars 61 forks source link

CSVDownloader fails to export all data #68

Open luuddan opened 3 years ago

luuddan commented 3 years ago

Hi!

When I'm using CSVDownloader the exported CSV file contains 59 rows of data of the 330 rows I expect. It's not a huge amount of data, the dowloaded CSV file is 51kb. Do I have to use some kind of stream when downloading larger amounts of data? I've just updated to version 3.9 but that didn't fix it.

Best Regards,

Ludwig

Bunlong commented 3 years ago

@luuddan What kind of error? Could you send me the screenshot?

luuddan commented 3 years ago

Sorry if I was a bit fuzzy in my problem description. I'm not getting any errors, but the problem is that my exported file only is 59 rows of the >330 it should be.

Bunlong commented 3 years ago

@luuddan I got your question. I just check it at the moment it work fine I could export more than 10000 rows . Could you please check code again esp the loop?

Bunlong commented 3 years ago

12140 rows, file size: 172kb

Screenshot from 2020-10-19 20-41-32

Screenshot from 2020-10-19 20-42-32

luuddan commented 3 years ago

Thank you for the quick responses! I found the error, turns out that some of the data had hashtags, '#', which caused the exporting to stop on that character for some reason. It worked perfectly now when I removed the hashtags

Bunlong commented 3 years ago

@luuddan You are very welcome. Could we close the issue?

luuddan commented 3 years ago

Yeah! Will there be support for hashtags in the future?

luuddan commented 3 years ago

@Bunlong ?

Bunlong commented 3 years ago

@luuddan I'm sorry for late response. Yes, it will support for hashtags in next version v3.9.1 and it will be published next week maybe.

GhostApps commented 3 years ago

Just want to say this is still broken

Bunlong commented 3 years ago

@GhostApps Could you please try the latest version?