search

Bunn / PiStats

macOS app to visualize Pi-hole information
BSD 2-Clause "Simplified" License
374 stars 12 forks source link

API Address #36

Open gpnunes75 opened 2 years ago

gpnunes75 commented 2 years ago

I use my pi-hole behind a reverse proxy. It automatically add a prefix /admin at end. So my public address is https://pihole.mydomain this way the api address https://pihole.mydoman/admin/api.php doesn't work.

My suggestion: Add a configuration to add a different api address or create a configuration to bypass reverse proxies.

gpnunes75 commented 2 years ago

I have done those modifications above.

I had to change swiftHole dependence and PiStats. I 'd like to know if I can help and send the modifications to add to those projects.

I put files below

SwiftHole.zip PiStats-master.zip

Bunn commented 2 years ago

Hey. @gpnunes75 thank you for that I appreciate it, but could you create a PR so it's easier for me to check out the changes? Feel free to reach me out on twitter (fcbunn) if you have any issues with it :)

gpnunes75 commented 2 years ago

I can do that. Just for clarification. I need to create a PR here and a another on SwiftHole?

gpnunes75 commented 2 years ago

OK, I made a PR to both projects. I Hope I have done right.

I have compiled and tested with no problem.