search

Bunny67 / WeakAuras-WotLK

World of Warcraft addon that provides a powerful framework to display customizable graphics on your screen.
GNU General Public License v2.0
161 stars 105 forks source link

Swing timer doesn't update in relation to attack speed changes. #31

Open Gettz opened 4 years ago

Gettz commented 4 years ago

The major cause of this is they Flurry talent https://wotlk.evowow.com/?spell=12974 for Warriors and Shamans. I would imagine other variable attack speed modifiers like Bloodlust and Speed potions would also break it, but they're less relevant since they are more static than flurry.

Here's a video showcasing how it works currently: https://www.youtube.com/watch?v=pVv3MEhiEYk as you can see when I get the flurry buff the swing timer progress bar hits 0 and disappears, and only catches up again until the next swing. So if you're gaining / losing flurry consistently 50% of the time your swing bar will not be visible.

I did some searching and someone reported the same bug in the Classic Weakaura port - https://github.com/WeakAuras/WeakAuras2/issues/1759 and it was fixed in the following commit: https://github.com/WeakAuras/WeakAuras2/commit/a9a3a8abeaa3b2e7ee52bb9e24aca4cfc4c47100

if that helps.

CH33T4 commented 3 years ago

Tried to solve this problem and came across a typo in GenericTrigger.lua at line 1518. It says: 

timer:CancelTimer(mainTimer, true);

should be:

timer:CancelTimer(offTimer, true);

Solved the problem for me. I am not familiar with github or pull requests. Hope it helps anyway.