Bunny67 / WeakAuras-WotLK

World of Warcraft addon that provides a powerful framework to display customizable graphics on your screen.
GNU General Public License v2.0
161 stars 105 forks source link

Desaturate via Conditions not applying every time #32

Closed Zidras closed 2 years ago

Zidras commented 4 years ago

I noticed that when trying to either apply or remove desaturation using conditions, sometimes they didn't work. I didn't do extensive testing on this to pinpoint how to reproduce this but I've seen it happen on my system and another person's system.

(I'll edit this when I have the chance to properly troubleshoot and create test auras if needed)

Bunny67 commented 4 years ago

I know about this problem, at the moment I don't know how to fix it

Zidras commented 3 years ago

I'd like to add on this the following: I have found a way to reproduce this bug everytime with range check triggers. I also have no idea where to look in the code for this, but I'm leaving this finding here nonetheless, should it be helpful in the future for bug catching.

New finding:

image

Show GCD toggle also causes this. Breaking the GCD check by editing out GCD_START event from the trigger code stops this bug, so it may be related

!WA:2!1vv0UnXruuSCraBLQiPQGsAvLlsnQGQqToLquFZBWMeKXoD8gcivj7z3D8Udz9mdZmRtms9bSeQWR(tWp0N6t(H(bKVGrwv8bWNq(c6DM1oaTf)W67CU39EpZzU3zl1y1bRgVA8RQmLgXzD45YiYxDH54CDkx2wOPCMYtoQD)(kIU0mmlcW3Ntz6WDQ3kOo60ioplMFmRECcj13MLEJ1sAscrQyBixy(h(6rcccNlXvNyFYWdiQ1rBw9h3UkImKajCxcotN6NZO6qrgEerowjizz7fR8ERkp0f1(ssF6jOo7xVzZZb7K3haN1DNADc62jOgka5YVNmxrAbw9MgtcHGcasi3TEZ9BCqZj5SfKZBdZvEKXZ8PNbHx)eCKUtrD7zUQzLtT01reAmW47C37wDtZAYDRHEiKfZxAF73G0sC0r(GUXnEix0IvGS1nHWisAuNu(XTz9mFMyTDwiyv2xYtKeLQY35k3nTfBUeeb3slTL7sKCQAWCBMulr7zwZS(8piXVv5(BzQN5IhGsII7n2UWkQ9MyTCeT3KZZ2L)T)c2dZIPQNMZI00HKQy2iXkyNDqHc9qEm5pVWzWXorYWzpcoBHoJNC2reIOgKQincd9kPtuKS(U2dZfbjxH1G2PjPtHtkejX2nDRxDDXQAYjAGGyGSpErVLynhO7rFUCagcyHHpJZito39n(wH4QVxg2HNXLpOuPsLFBb6so4x7GG2Ip3bApzGurJoKgdnz1GLNvul6jKyh4lMx0E)Kfm6uN)NMR00(Jmx04jHDHfBQZrKRSLHFtwqAMwC1gs6ZR8l54yyFJReem)CFUEV2he0CVw1)afyz9wu(LcsXBEmxgFOelgF4cJcwnKQOHzKEleI3BUuSYETAvh11VDqq7hI27(7gi(6)J0k6QPdilw9)P9IfgiBCXVBx0H(CYAIB(Xsy8iyWJg1vNcD2Pq34iX38XIvijruBFu53mpjJFCdj5z5ew0O9)KF42vVtHEBDmZ(yPSm2UWQLZdZ1AoR9qIeUSyQfUjHLOt)cx8lv1j2f7C(z1PWmW9xIK6BDM6QEqkn6igmow29gDIWzKcZMuaEfxb8HdbImnmLqts1VWpJJJBeQHqz6RHgKNPPE(25HRz67HIYWkL1YxbQM1yQ0neyPV5sYtwETkLvOmGlp)NZ5dknbZOfaBHuASu34ucwr6OLUT4LGBR2EESD4ccPR9UvPIa39gRgBJZvGT9hGPSggHlAZZmsJYSDyFkJQs)3Wt18OHfJ1xE4VEdAS463RU)b3)NRC(ym4QsyEYzfnBnKWLh26e2zhu96TM13caee67lJo2nqHE3ms1CA8SGKnrpO1J2kmagty2YrsL2lAG7f2YW9m5E(a70EHWwPpnXBQDlrD(xFduukj6OTmx57VW4HyjfddavR16EHoC1TapLnV03EVhAiolNuQH5kx08sZRmVUS53xFR3TsgLIzjWhG2W86EJfsoOF6rMFA8YVM1dHZeP4YRQqBE7Q3EZvh(3p(F(d
!WA:2!1rvZUTXnq4iOA4K9qrScAdsArHAaQbAoe0kd7a0BAvLSDGIKl168dqrL4Ul1UmEfjljxzRa0dwPhYz9iOd9upPd9bWpbecf5bipc(jOdPw5K02OdAhoZWVzMVzgwQvLrvIRe)6QZPrCwpEUmI8LxBjoxNYLDfAkNP8Kt6oCOIOlTaZIa9hXPmDyJMDcAIUiIZZI5NYAgNqs9TOmyQwstsis1VSTSq8p81teeeoxIR9wvEizmHP7LpCi9Sf9BuVxq)Eb1rbiN(Wdi4mDkIHhruEtvcsw2HXkp)CgvhkYWtiYRa5ijbab17OMTBFzUI08mCKU3QRm4cBaD3NgRUlA3h(WA7mpMecboaYh5b1rpU1XTNLZkYtVTn34niTehDIpqcCJhYDDXwa09timIKg1lLFAx2aZNE5(z8qCw1gfCWuRt2KCWcRKc8ljkEWs3blmDGkAWSReV(V9xl)amFRY9znElLar0BT3YdisovnYuXCRzwiDP5aZDKh0S9rqzy(cVfXu1lYzrA6ysnmBIylStoyv59yEm5pV2Lq7Jiz4SNa9iOd)8lpHqe1H0ksJWqppDMIKn01MnBa8LcRbEutsNdSoIKyNkU)RVT4R1KZ09D)nKlhH19f910rK(cjjIAHUS4o)hFufc(moJm7kZ37BeIB6oPsXq13GNXLpQuPsLF7kTRtj)6hh0vClNsBpcGIg9uASo1VoC8YvXIEgj2P88LRMAFEXq8fo7VixPPdNy2W4jHIYQBUZqKlSLHFZksAMwCZws6lR(t54yGgWvdcevEVm9zfi)bkxhoX3(XiP4jWaonQVovsG(Ew8KLoVoLlJFQelM(0cHvz8yGqdZidkiP3BvuS1HD60e13VBqq3hJoC)dceF1hlQRov6)PVikeqw)IxEv13J(sYDkiX1L67S62J6ECq7d708nltY4N2ss(1CclAYrFY39GA7UIGTgwy)BnctThSxEzyUwZzDhtKWM9CR62ewIo9ZC(VMhNzp04QMZfWcW(R1K6BnM6CPxeoJu2LibP0OtyeLQSZsBkiVLla(aZsKPHPeAsQ(C)mooULVck0phnkptt98TBdFUjYdfLHvkRuOgqMPTIZLULaB6B2CgMrTZGC2EiLgl1TmEMDVGGvKEAPRu2CzSDbcCPV9DqPIaVtgRMA9XbYU(JWuM7IMxSP5etMzKz3WHugvL(VvpD9BUd8FjNpQK0UJdRK7zG8gUH2ZW9MR5rJxTFF9X)89OXIB)Jn9pE)FO6v7ZGPQH5jiCMifxEXqj8idKXWeEz0PUvh072gcHmEinXtszwyjPYZk6m1YPXlcs2b9OopzVWGwZT1g1Lr3DBuukj6KwMBuE6ySKIHjyF7JCOX4SCcGQ1S6(BBEvjZ5MPwhTFnVQS53V7EMBSrXjzukMLqaenVAWuHKdSOEI57xqzRMAHW5D5QH0w2cXsRH9AGA2StffANhu7b7uz8F)S)5

https://user-images.githubusercontent.com/10605951/147852616-ef4b0a1d-d3a0-41c2-bab1-f7092e75bd8d.mp4

Zidras commented 2 years ago

Closed by https://github.com/Bunny67/WeakAuras-WotLK/commit/5e69aa3ebec5e7d1a8b8bd3a2f68af725764307f