BunnyCinnamon / BetterHurtTimer

Better Hurt Time Attack Frames
MIT License
5 stars 7 forks source link

Incompatibility with project: war dance (again) #22

Open Jackiecrazy opened 3 years ago

Jackiecrazy commented 3 years ago

Jackiecrazy/WarDance#18 Mobs with weapons cannot attack. I increment tickssincelastswing of mobs for the sake of tracking whether a mob has their hand cooled for an incoming parry, and it appears that this makes BHT cancel attacks at line 149 (my event handler has very slightly lower priority than yours due to load order). While I can fix this on my side, it may cause issues somewhere down the line if another mob also decides to increment its tickssincelastswing to emulate an attack cooldown, so I'm cross-posting it here.

BunnyCinnamon commented 3 years ago

oh shit, this mod was a mistake

BunnyCinnamon commented 3 years ago

thought this was OffHandCombat my bad, still the same holds true, both mods cause trouble to others, Im sorry :<

Jackiecrazy commented 3 years ago

I fixed stuff on my end so it's all good, just wanted to give a heads up.