search

BunnyCinnamon / BetterHurtTimer

Better Hurt Time Attack Frames
MIT License
5 stars 7 forks source link

Mekanism's Atomic Dissasembler deals 1 damage (instead of 20) #5

Closed Krutoy242 closed 4 years ago

Krutoy242 commented 4 years ago

MC: 1.12.2 Forge: 14.23.5.2847 BHT: 1.3.0.0

When hitting, Atomic Disassembler from Mekanism mod usually deals 20 constant damage, but with BHT only 1. Expected similar to hand attack, but with 20 damage.

Hit video: https://imgur.com/xIvdFgj

BunnyCinnamon commented 4 years ago

I found out why... and its not pretty. Mekanism is hitting the same entity twice in the same game update here, this is not possible under normal circumstances............. this is incredibly wrong on their part as hit damage is NOT meant be applied like that, they should've made it an Additive Attribute like regular weapons do...... one bad thing about it is armor wears down FASTER if you do this (twice, once for the initial hit of 1dmg and once for the 19dmg).

I know how to fix it however and thinking about it this might not be the only mod that fucks up this bad, I will fix their mistake but in a way break other stuff on its course.

Thank you for the bug report :>

BunnyCinnamon commented 4 years ago

Expect a beta by tomorrow and sorry for the small rant 🧶

Krutoy242 commented 4 years ago

Thank you for fast reaction!

BunnyCinnamon commented 4 years ago

Fixed.

BunnyCinnamon commented 4 years ago

1.12.2-1.3.0.1 is on curse now

Krutoy242 commented 4 years ago

New fixes in one day! So fast, thank you. Gonna check out in few days.