search

BunnyCinnamon / OffHandCombat

Allows for double handed fighting styles without breaking the combat"
MIT License
7 stars 2 forks source link

[1.16.5] Client Crash | [Wardance mod incompatiblity] Critical injection failure: Redirector tickHand #5

Closed Cixon closed 3 years ago

Cixon commented 3 years ago

Using latest version. -> (v3.2.0.3) Using Forge version. -> (36.0.42) Using Mixing Bootstrap version. -> v1.0.5

crash-2021-03-05_15.15.43-client.txt latest.log Line 51.

Cixon commented 3 years ago

Addition context: I was using a mod called Project: War Dance, this seems to have caused the OffHandCombat to throw the error.

War dance is a pretty stable mod and would work great with OffHandCombat. The mod recreates vanillas combat system from the ground up adding a parry system and staggering. Would love compatibly for it!

BunnyCinnamon commented 3 years ago

That is because that mod is overriding the offhand modifications I do to the game, as long as that happens the mods will be incompatible

BunnyCinnamon commented 3 years ago

The only solutions is either of us completely overrides interfering changes, and it's possible it'll start an arms race.

BunnyCinnamon commented 3 years ago

A solution I'd prefer (but might not happen) is they remove the offhand aspect of the mod, since what they do is also not entirely correct, and add this mod as an optional dependency.

They could leave the attack speed game modifications unchanged, that was done correctly enough I believe.

yeah

Cixon commented 3 years ago

They could leave the attack speed game modifications unchanged, that was done correctly enough I believe.

This would be enough?

BunnyCinnamon commented 3 years ago

Yeah they just have to remove the offhand attack from their mod.

Jackiecrazy commented 3 years ago

Why is it not quite correct? The original offhand attack function of PWD came from its predecessor, Taoism, so I know the current function is extremely hacky. I can remove it, but I'd like to know how I can improve for the future.

BunnyCinnamon commented 3 years ago

Oh no nvm, I assumed you were doing it the wrong way by copy pasting the attack logic for the offhand because you mention an offhand attack event, but you actually swap the items and apply the attributes like should be. You're good Sorry :<

BunnyCinnamon commented 3 years ago

I'd say just copy what I do in this mod add a incompatibility warning so people don't install this by mistake.

Cixon commented 3 years ago

i- so, huh?

BunnyCinnamon commented 3 years ago

ah oops, so Project:War Dance mod already adds off hand attacks, you don't need to install this mod