nus-se-bot
commented
1 week ago Team's Response
Thank you for pointing this out. Firstly, we feel that the severity of this is low, given that we have already given a warning, and editing the data file is as advised, only for experienced users. Furthermore, we determine this issue to be NotInScope given that we feel it is of low priority. We have already implemented an additional security layer to save data, as shown in the screenshot. If values added are invalid, e.g. if a phone number accidentally has a letter, that patient and their tasks would simply be skipped, and the application will run as per normal, without that entry. The application will only discard all data and reset if the data file itself is invalid, meaning that for example, if one patient does not have the entire name field. If any of the field themselves are invalid, the entry will be skipped. With this additional layer of check, we have already gone the extra mile to reduce chances in which the data file would be wiped and reset. Hence, we feel that having the data file itself being invalid is extremely unlikely and think that this is of extremely low priority, compared to what was released.
Items for the Tester to Verify
:question: Issue response
Team chose [response.NotInScope]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I believe that the severity is still medium, because the issue is the all data for a single patient will be deleted if any data for that patient is considered invalid (Perhaps an extra dot in the name, as a typo). It is true that a warning was given and editing the data file is for experienced users. I would reasonably expect that after using NovaCare for a short while, users would be relatively familiar with NovaCare. Furthermore, users might feel that there is a lot of data to edit at once and might prefer to edit the data file instead of having to key in commands for every single change. This issue might cause occasional inconvenience to these users who have used NovaCare for awhile, since they have to add the person into NovaCare again, hence the application is still usable and the severity is medium. The severity should not be low because this situation can be more than rare since experienced users might prefer editing directly for ease and convenience, and typos can be quite common, and adding a patient once again and all the tasks related can be considered more than a minor inconvenience. I agree that this would be not in scope since there were clear warnings in the UG.
Feature: NovaCare will delete all data for one patient if the data file has an incorrect value.
Patient data is very important and should not be deleted immediately when there is a slight mistake in typing. Nurses who wish to change the data file and make a slight typo might have very major consequences in losing all the patient's data which would be very bad.
This mistake might not happen often but could be detrimental for some users when they make a slight mistake in editing the data file.
Users might be unwilling to edit the data file even if they are confident, considering that typos can be quite common when typing.