BunsenLabs / bunsen-pipemenus

A collection of Openbox pipemenus for use with BunsenLabs
https://pkg.bunsenlabs.org/debian/pool/main/b/bunsen-pipemenus/
GNU General Public License v3.0
29 stars 11 forks source link

Scripts called from bunsen-utilities: test before adding menu item? #42

Closed johnraff closed 8 years ago

johnraff commented 8 years ago

This is already done in many places in the pipemenus, but if all calls to scripts in bunsen-utilities were preceded by a test before adding the menu item, like this in bl-tint2-pipemenu:

loadRestartmenu(){
    if [ "$(pidof tint2)" ];then
        if type bl-tint2restart &>/dev/null;then  # bl-tint2restart script found
            menuItem "Restart Tint2" "bl-tint2restart"
        fi
    fi
}

then bunsen-utilities would not have to be a hard dependency of bunsen-pipemenus. A Recommends: would be enough, and the menu items needing those scripts would just be missing if the package wasn't installed.

For example, at present there is no such test for bl-tint2zen in the same pipemenu.

johnraff commented 8 years ago

Now fixed in bunsen-pipemenus 8.8.4-1 .