BunsenLabs / bunsen-utilities

https://pkg.bunsenlabs.org/debian/pool/main/b/bunsen-utilities/
GNU General Public License v3.0
30 stars 21 forks source link

bl-hotcorners rewrite #19

Closed Hjdskes closed 4 years ago

Hjdskes commented 9 years ago

I enjoyed rewriting bl-aerosnap and contributing to BunsenLabs so much that I also took a look at the other python scripts. Whilst I'm waiting for feedback on my bl-aerosnap rewrite, I'm now working on bl-hotcorners. You can find it in the rewrite-hotcorners branch of my fork.

bl-hotcorners is supposed to run as a daemon. The current code, however, does not implement proper daemon behaviour. After a bit of searching, I came acros python-daemon which does all the tricky work for you. I'm wondering if I can make bl-hotcorners depend on that. The package is available in Jessie.

Otherwise, I can copy this code, which also does a lot of the heavy lifting.

hhhorb commented 9 years ago

I enjoyed rewriting bl-aerosnap and contributing to BunsenLabs so much that I also...

To quote Roy Batty in Blade Runner, "THAT'S THE SPIRIT!!!!"

:grinning:

johnraff commented 9 years ago

^ YAY! @Unia I'd say use the python-daemon package, rather than copy in the code. Maybe in the future someone else might want to use it. We can make the package a dependency (or possibly recommend, since it would only be for bl-hotcorners) of bunsen-utilities.

hhhorb commented 9 years ago

Recommend, please. I'm sure the daemon is light on RAM, but these things have a cumulative effect.

johnraff commented 9 years ago

@Unia can the user control whether the bl-hotcorners daemon runs or not? Would it be an entry in openbox/autostart?

If so, then @hhhorb having the python-daemon package installed would have no effect on RAM usage unless the user was running the bl-hotcorners daemon. We could have it commented-out of autostart by default.


If I understand it correctly, python-daemon is just a library that python script writers can use. It doesn't run any daemons on it's own. Right Jente?

Hjdskes commented 9 years ago

Yes the user will be able to control it. Something along the lines of bl-hotcorners --start and bl-hotcorners --kill or --stop.

Using python-daemon will require the package to be installed (so it can not be a recommend), but it is just a module (library) for bl-hotcorners (and other python scripts) to use. It is not a daemon in itself and thus has no effect on RAM usage. (Which I'll measure once I have something working)

johnraff commented 8 years ago

@Unia where are we now with this?

And, is the current GitHub bl-aerosnap your rewritten version? I can't see any traces of commits by you.

Hjdskes commented 8 years ago

My (still unfinished) code can be found in my fork: https://github.com/Unia/bunsen-utilities/tree/rewrite-hotcorners

However, I haven't worked on it for several months now.

johnraff commented 8 years ago

OK, so we'll stay with the existing code for the time being. I tried it yesterday and agree that it doesn't behave as a daemon should, so look forward to your new version!

Hjdskes commented 8 years ago

I have rebased my changes on top of the current master branch and will probably start working on this again the coming few days.

johnraff commented 4 years ago

For lack of interest, bl-hotcorners has been removed from bunsen-utilities.