search

BunsenLabs / bunsen-utilities

https://pkg.bunsenlabs.org/debian/pool/main/b/bunsen-utilities/
GNU General Public License v3.0
31 stars 21 forks source link

Blob sysdir #62

Closed johnraff closed 6 years ago

johnraff commented 6 years ago

/usr/share/bunsen/utilities/blob/ is added as a config path, along with $HOME/.config/blob Any themes in the user directory will be displayed first, and if there is a theme in both directories with the same name, the config details for restoring will be taken from the user version, although both will be displayed. User themes can be deleted, but not system themes.

Enabling restoration from a system theme with the same name as a user theme would require storing the full path, not just the name. This is possible, but would add complication to the code - I have tried to keep changes to a minimum. If this version is used, then the BLOB themes can be removed from /usr/share/bunsen/skel, so the user directory will be empty for new installs and only the system presets will be displayed. Users who create new themes can be expected to choose new names, so the name clash issue might not be serious..

johnraff commented 6 years ago

One simple workaround for the issue of having themes with the same name (as in the system dir) remaining in upgrading users' ~/.config/blob is to change the names of all the themes before shipping them in the new system directory. Users who then deliberately created new themes with the same names as those can be reasonably considered to be wanting to override them, no?

tknomanzr commented 6 years ago

^ That would be the behavior that I would expect.

johnraff commented 6 years ago

I think the revised bl-obthemes script now handles its new duties OK.

johnraff commented 6 years ago

BTW the package installation functionality requires bunsen-common to be upgraded to the latest version, 9.0.3-1 released yesterday fixing a bug with bl-installer.

johnraff commented 6 years ago

Now merged into helium-dev.