search

BuoyantIO / emojivoto

Example application to help demonstrate the Linkerd service mesh
Apache License 2.0
196 stars 154 forks source link

pprof endpoints #103

Open brancz opened 3 years ago

brancz commented 3 years ago

Hey :wave:

We'd love to use emojivoto as an example workload in @PolarSignals. To produce some data for Polar Signals Continuous Profiler we'de love to add pprof endpoints to each of the components. Would you be open to us adding the pprof endpoints in a similar manner as the prometheus endpoint? If you prefer we can also generalize them into a single "telemetry" port.

Let me know what you think, we're happy to take care of it!

olix0r commented 3 years ago

@brancz This sounds like a great addition! We'd welcome this change.

+1 to serving these endpoints on a separate admin server if they're not already

brancz commented 3 years ago

There is already the PROM_PORT. I would propose to rename it to TELEMETRY_PORT and serve both the prometheus and the pprof endpoints under it, but don't feel strongly about it whatsoever, so if you prefer a separate PPROF_PORT, I'm totally ok with that as well.

olix0r commented 3 years ago

@brancz Yeah, let's unify it as either TELEMETRY_PORT or ADMIN_PORT. Thanks!

brancz commented 3 years ago

Sounds good!

brancz commented 3 years ago

I started working on this, but I think I have mismatching versions of protoc and plugins from what this is built with. Do you mind if I update things to the latest version or let me know which version is being used to build this?

alpeb commented 3 years ago

Thanks @brancz, upgrading to the latest protoc version sounds great!