BuoyantIO / slow_cooker

A load tester focused on lifecycle issues and long-running tests
Apache License 2.0
327 stars 26 forks source link

consider automated docker hub build #48

Closed siggy closed 7 years ago

siggy commented 7 years ago

The Dockerhub section of our release process could be replaced with an Automated Build on Docker Hub. It works via Docker Hub listening for changes on the Github repo. A change in the master branch triggers a new latest docker image. A new git tag/release triggers a new tagged docker image.

It also provides some additional context when viewed on Docker Hub, including the Dockerfile, note the differences between: https://hub.docker.com/r/buoyantio/slow_cooker/ https://hub.docker.com/r/buoyantio/linkerd-viz/

A downside to this setup is we can't change an existing Docker Hub repo to be an Automated build. We have to delete it and recreate. There's currently one tagged image, 1.0.1, which we could manually push once the repo is replaced.

Thoughts? /cc @stevej

stevej commented 7 years ago

You're right, the Automated Build page looks much better. I say go for it.