search

BuoyantIO / slow_cooker

A load tester focused on lifecycle issues and long-running tests
Apache License 2.0
327 stars 26 forks source link

Fix “case-insensitive import collision” #55

Closed obeattie closed 7 years ago

obeattie commented 7 years ago

When building slow_cooker locally (under go1.8, in case it's a recent thing), I get:

can't load package: package github.com/BuoyantIO/slow_cooker: case-insensitive import collision: "github.com/BuoyantIO/slow_cooker/vendor/github.com/codahale/hdrhistogram" and "github.com/buoyantio/slow_cooker/vendor/github.com/codahale/hdrhistogram"

So I updated all the things to use the canonical BuoyantIO/slow_cooker form. 👓

stevej commented 7 years ago

I'm not sure if it's 1.8-specific but it's the first we've seen this bug. Thank you for the patch!

stevej commented 7 years ago

Oliver, I ended up reverting this change because I missed that there was differing internal feedback about how to address this. We'll come up with a plan to fix ASAP.