search

BuoyantIO / slow_cooker

A load tester focused on lifecycle issues and long-running tests
Apache License 2.0
327 stars 26 forks source link

Add support for reading list of target urls from a file #62

Closed richardmarshall closed 6 years ago

richardmarshall commented 7 years ago

When the test target string starts with an '@' it will be interpreted as a file path to load a list of URLs.

Resolves #50

richardmarshall commented 7 years ago

We've been testing out this mechanism for a few weeks internally and it's worked out well for us.

wmorgan commented 7 years ago

@richardmarshall thanks! Would you mind signing the CLA at https://buoyant.io/cla/ ?

richardmarshall commented 7 years ago

@wmorgan Yeah, I'll work on getting that sorted out.

richardmarshall commented 7 years ago

CLA is being reviewed by our legal team now.

richardmarshall commented 7 years ago

@wmorgan Do you have a legal contact I can forward some comments to from our legal team regarding the CLA?

wmorgan commented 7 years ago

@richardmarshall you can send those to me (william at buoyant dot io) and I'll forward them as appropriate. Thanks!

richardmarshall commented 7 years ago

Thanks, will do

richardmarshall commented 7 years ago

@wmorgan Just wanted to check in and see if you've received the doc file from our legal folks.

ahume commented 6 years ago

Would be great to see this picked up again.

wmorgan commented 6 years ago

@richardmarshall I did receive the doc, but we decided it wasn't feasible to maintain unique CLAs for contributors. Sorry for not updating this ticket to reflect that.

However, we've moved to a DCO approach in this repo (and the Linkerd repos), which lowers the burden on you substantially. Take a look at the DCO file in this repo, and if you agree with what it says, a git commit --amend -s will add a signoff to your commit. Then we can merge this.

richardmarshall commented 6 years ago

@wmorgan No worries.

Rebased by branch, resolved the conflicts, and added the signoff.