search

BuoyantIO / slow_cooker

A load tester focused on lifecycle issues and long-running tests
Apache License 2.0
327 stars 26 forks source link

Add -iterations to specify a budget for the experiment #68

Closed farquet closed 5 years ago

farquet commented 6 years ago

If iterations is greater than 0, the experiment will not be infinite, but print N reports and exit automatically afterwards.

siggy commented 6 years ago

Hi @farquet, thanks for the PR.

Question: There's already an existing totalRequests flag that governs how long slow_cooker runs. Do you have a use case where that flag is not sufficient, necessitating this new iterations flag?

farquet commented 6 years ago

For _slowcooker I agree. To get iterations iterations printed, one can set totalRequests to iterations * concurrency * qps * interval in seconds.

But there is no such mapping for strest-grpc. This PR is here for consistency.

farquet commented 5 years ago

Following on the remark from https://github.com/BuoyantIO/strest-grpc/pull/55 , changed cleanup := make(chan bool, 2) into cleanup := make(chan bool, 3) since a third place in code can trigger a cleanup.

wmorgan commented 5 years ago

Thanks @farquet!