search

BurdaMagazinOrg / module-ad_entity

A Drupal module which provides consolidated integration for various types of advertising instances.
GNU General Public License v2.0
1 stars 4 forks source link

DFP is not displayed #19

Closed milkovsky closed 6 years ago

milkovsky commented 6 years ago

Using beta11. Ads are not displayed for "Default HTML view for a DFP tag". https://github.com/BurdaMagazinOrg/module-ad_entity/pull/18

mxhCodes commented 6 years ago

Thanks for the report & PR. Could you give a little bit more detailed description about the given problem?

I'm currently not sure why

googletag.display(ad_tag[0]);

is causing the problem and that

googletag.display(ad_tag.data('id'));

would solve it, since both ways should be valid as seen in the documentation of DFP regards googletag.display(div):

Either the ID of the div element containing the ad slot or the div element itself. If a div element is provided, it must have an 'id' attribute which matches the ID passed intogoogletag.defineSlot().

I've seen drastically reduced ad displays on my development environments, which are running under different domains than production environments. But I couldn't determine which change in the refactored code causes the display problem. Even my stage environment, which has not been updated to beta11 and is still equivalent to my (still working?) production environment, yet now behaves exactly the same as my dev environment running with beta11. It's confusing.

milkovsky commented 6 years ago

Unfortunately I can not provide any helpful details. I am using just DFP Ads provider, only locally for now. I have tried beta11, it did not work: I do not see any error, the Ads are just not displayed. beta10 worked for me; after some debugging, I figured out that this change broke Ads display for me.

mxhCodes commented 6 years ago

I'm unable to identify the source of the problem. To make the ads at least working on your environment again, I'm just including your PR into the next commit, and will create a new release today.

milkovsky commented 6 years ago

wow, thanks a lot!