BurdaMagazinOrg / module-ad_entity

A Drupal module which provides consolidated integration for various types of advertising instances.
GNU General Public License v2.0
1 stars 4 forks source link

DFP: Support native ads #22

Open milkovsky opened 6 years ago

milkovsky commented 6 years ago

Currently every ad is embedded as an iframe. There is also a possibility to ad native "fluid" ads in DFP. Currently "fluid" size is not supported as well. See: https://support.google.com/dfp_premium/answer/7438314

milkovsky commented 6 years ago

Examples: http://dfp-native-demo.appspot.com/2

mxhCodes commented 6 years ago

So we basically only need the possibility to add 'fluid' into the text field for ad sizes, right?

mxhCodes commented 6 years ago

I'll have a look at it

milkovsky commented 6 years ago

I have tried adding fluid to the sizes. But it anyway renders an iframe in the end. Looks like we should add a new view handler.

jintnc commented 6 years ago

according to HJP from burda studios, DFP's native ads can't be shown in an iframe, here is his article/workaround for "Bunte": http://insights.burda-studios.de/howto-run-fully-responsive-doubleclick-native-ads-without-iframes/

mxhCodes commented 6 years ago

I think we talk about two separate things here:

According to https://support.google.com/dfp_premium/answer/6366910?hl=en native ads are always being rendered as "SafeFrames" by default for web apps, which are iframes in the end. This is basically what the "default HTML view" currently does.

Conclusion: We need to

milkovsky commented 6 years ago

ok. it looks like fluid should be enough. the http://dfp-native-demo.appspot.com/2 demo uses iframes as well.

mxhCodes commented 6 years ago

Ok, let's use this issue regards native ads support only, and optionally create a new on regards custom rendering. Issue for custom rendering: #23

mxhCodes commented 6 years ago

Please try and let me know if 7361f23 is working for you.

milkovsky commented 6 years ago

Works great, thanks!