Support error checking for all methods that received it in libspotify v12

[Burgestrand]

Not quite sure what to do about release, since it gets called as a result of ruby GC. Then again, it’d be nice to know if it fails (because it shouldn’t!).

• session_release
• session_process_events
• session_login
• session_forget_me
• session_logout
• session_set_cache_size
• session_player_play
• session_player_seek
• session_player_unload
• session_preferred_bitrate
• session_set_connection_type
• session_set_connection_rules
• session_preferred_offline_bitrate
• session_set_volume_normalization
• session_flush_caches
• sp_link_add_ref
• sp_link_release
• sp_track_set_starred
• sp_track_add_ref
• sp_track_release
• sp_album_add_ref
• sp_album_release
• sp_artist_add_ref
• sp_artist_release
• sp_albumbrowse_add_ref
• sp_albumbrowse_release
• sp_artistbrowse_add_ref
• sp_artistbrowse_release
• sp_image_add_load_callback
• sp_image_remove_load_callback
• sp_image_add_ref
• sp_image_release
• sp_search_add_ref
• sp_search_release
• sp_playlist_add_callbacks
• sp_playlist_remove_callbacks
• sp_playlist_set_collaborative
• sp_playlist_set_autolink_tracks
• sp_playlist_subscribers_free
• sp_playlist_update_subscribers
• sp_playlist_set_in_ram
• sp_playlist_set_offline_mode
• sp_playlist_add_ref
• sp_playlist_release
• sp_playlistcontainer_add_callbacks
• sp_playlistcontainer_remove_callbacks
• sp_playlistcontainer_add_ref
• sp_playlistcontainer_release
• sp_user_add_ref
• sp_user_release
• sp_toplistbrowse_add_ref
• sp_toplistbrowse_release
• sp_inbox_add_ref
• sp_inbox_release

[Burgestrand]

That’s a long list, and there’s more methods in libspotify that already have some kind of error handling. Will probably add bang methods to the Spotify gem for all methods that return an error, which will be the equivalent of the non-bang version except it raises automatically.

[Burgestrand]

The base for this is in place. Just need to review every single one of these methods now.

[Burgestrand]

Most of these methods always return the same error code, and not all of them make sense to raise an error when the operation fails. I’m not quite sure where my stand on exceptions for some of these methods is.

[Burgestrand]

List of functions that actually need treatment:

• sp_session_preferred_bitrate
• sp_session_preferred_offline_bitrate
• (new scrobbling methods, some are unknown)
• sp_track_set_starred (unknown)