Revisit all buffer_out parameters

Burgestrand / spotify

Low-level Ruby bindings for libspotify, the official Spotify C API

https://rubygems.org/gems/spotify

Other

146 stars 17 forks source link

Revisit all buffer_out parameters #19

Closed Burgestrand closed 10 years ago

Burgestrand commented 11 years ago

Would be neat if spotify could make dealing with buffer_out parameters a little nicer. Perhaps wrapping the functions? There is only like two of them that do not have a clear better implementation.

[x] image_data
[x] link_as_string
[x] link_as_track_and_offset
[x] playlist_get_image
[x] playlistcontainer_playlist_folder_name
[x] session_create
[x] session_process_events
[x] session_remembered_user
[x] session_is_scrobbling
[x] session_is_scrobbling_possible

Burgestrand commented 10 years ago

Still have create_session left, but I'm not sure what to do with it considering the error return value is also of great importance.

Burgestrand commented 10 years ago

While I'm breaking backwards-compatibility, I might as well make all functions that previously returned an error, raise the error. In pretty much all cases that's what you want anyway?

Burgestrand commented 10 years ago

Here are some more functions that could get some sugar:

[x] playlist_add_tracks
[x] playlist_remove_tracks
[x] playlist_reorder_tracks
[x] playlistcontainer_get_unseen_tracks
[x] track_set_starred
[x] inbox_post_tracks (uses callbacks)