search

Burgov / KeyValueFormBundle

A form type for managing key-value pairs
MIT License
44 stars 32 forks source link

Add Symfony 3 support #15

Closed wouterj closed 8 years ago

Burgov commented 8 years ago

These if statements and checks for methods and classes look kinda hacky to me. Is this really the way to build sth that's compatible with both? (This is just a small library, I can't imagine the hell in a big one)

wouterj commented 8 years ago

Unfortunately, yes it is if you want 2.3 and 3.0 support (methods of 3.0 aren't available in 2.3 and methods available in 2.3 are removed in 3.0).

This is why I expect many bundles to support 2.3 - 2.8 or 2.8 & 3.0, but not the complete 2.x serie and 3.0 (the CMF is going to do this btw).

Burgov commented 8 years ago

Ok, at some point we should bump the major on this bundle and discontinue 2.x support, but that's far ahead I suppose.

wouterj commented 8 years ago

Yeah. For the most part, supporting 2.6+ is already enough (only the getName -> getBlockPrefix renaming requires 2.8+).