search

Burgov / KeyValueFormBundle

A form type for managing key-value pairs
MIT License
44 stars 32 forks source link

use FQCN form types instead of names #22

Closed mathroc closed 8 years ago

mathroc commented 8 years ago

follow 2.8+ recommendations

Type names were deprecated and will be removed in Symfony 3.0. Instead of referencing types by name, you should reference them by their fully-qualified class name (FQCN) instead.

also makes it easier to use without having to register the type beforehand (if used outside of the Symfony Framework).

ElectricMaxxx commented 8 years ago

Will there be a completely 3.0 compatible version of that bundle? That means without any $isSf28 = method_exists('Symfony\Component\Form\AbstractType', 'getBlockPrefix'); ?

mathroc commented 8 years ago

@ElectricMaxxx it's not that hard to supports previous 2.x versions so I guess it does not makes much sense to drop support for Symfony < 2.8 before 05/2019 (Sf 2.7 end of life)

Burgov commented 8 years ago

Is this safe to merge?

mathroc commented 8 years ago

@Burgov I think so