search

Burgyn / MMLib.SwaggerForOcelot

This repo contains swagger extension for ocelot.
MIT License
353 stars 94 forks source link

Added feature with multiflile configuration in ocelot and swagger #109

Closed dadjh85 closed 4 years ago

dadjh85 commented 4 years ago

@Burgyn Here I leave you a pull request of what we have been talking about days ago, sorry for the delay in sending it, but I have been busy for several days. There is a lack of documentation, but if you like the code I will write the documentation because if not, it is not worth to write it.

Burgyn commented 4 years ago

Hi, thanks for your PR. I'll look into it tomorrow.

In the meantime, can you please try to resolve the merge conflicts?

dadjh85 commented 4 years ago

Hi, thanks for your PR. I'll look into it tomorrow.

In the meantime, can you please try to resolve the merge conflicts?

I can't click the button to resolve the conflicts, the button appears disabled, you may not have permission for this action. i read this text: "Only those with write access to this repository can merge pull requests."

Burgyn commented 4 years ago

Hi, thanks for your PR. I'll look into it tomorrow. In the meantime, can you please try to resolve the merge conflicts?

I can't click the button to resolve the conflicts, the button appears disabled, you may not have permission for this action. i read this text: "Only those with write access to this repository can merge pull requests."

Hi, yes, button is disabled. But you can merge master branch to your branch and resolve conflicts. Thanks.

Code looks good, I wrote some issues directly to code. Please check it. Thanks a lot.

dadjh85 commented 4 years ago

Hi, thanks for your PR. I'll look into it tomorrow. In the meantime, can you please try to resolve the merge conflicts?

I can't click the button to resolve the conflicts, the button appears disabled, you may not have permission for this action. i read this text: "Only those with write access to this repository can merge pull requests."

Hi, yes, button is disabled. But you can merge master branch to your branch and resolve conflicts. Thanks.

Code looks good, I wrote some issues directly to code. Please check it. Thanks a lot.

Ok, this week, I'll review the changes and update this pull request.

dadjh85 commented 4 years ago

Hi @Burgyn, I'm updating this pull request with the changes you mentioned and also I've updated the demo project to work with multiple swagger files inside the configuration folder, I've added the different ocelot.SERVICE.json files, I don't have much experience with this kind of tests focused on components, but I've been checking over and maybe I can try to implement these tests, anyway if I have any complication or doubt I'll tell you if you help me to complete or finish them, otherwise you can check the update of this pull request

Burgyn commented 4 years ago

Hi,

thanks. I will write unit tests later.

One unit test began to fall. Will you look at it? ReturnUriFromServiceDiscoveryWhenRouteDoesntExist

dadjh85 commented 4 years ago

Hi,

thanks. I will write unit tests later.

One unit test began to fall. Will you look at it?

OK, fine, I'll try and look at it today, the test that fails, by tomorrow at the latest I should have it sorted out.

dadjh85 commented 4 years ago

Hi,

thanks. I will write unit tests later.

One unit test began to fall. Will you look at it? ReturnUriFromServiceDiscoveryWhenRouteDoesntExist

Hi, I've already fixed the test that failed and I've also written the documentation about the developed feature

Burgyn commented 4 years ago

Hi,

thanks a lot. This feature will be available in version 2.4.0 soon.