search

Burgyn / MMLib.SwaggerForOcelot

This repo contains swagger extension for ocelot.
MIT License
352 stars 94 forks source link

Aggregates address #166

Closed Burgyn closed 3 years ago

Burgyn commented 3 years ago

There is no need to make HTTP call to yourself in case of Gateway it self or Aggregates route. We will use ISwaggerProvider for that.

update-docs[bot] commented 3 years ago

Thanks for opening this pull request! If you have implemented new functions, write about them in the readme file.

samuelpratt commented 3 years ago

Thanks :-) This seems to fix the issue. However, when testing I did notice something else:

When testing I upgraded all my Nuget packages.

When I upgrade Swashbuckle to v6.0.1 it introduces another error. It would appear that the maintainers of this package changed the interface to Swashbuckle.AspNetCore.SwaggerGen.SchemaRepository in v.6.0.1. This produces the following error: -

System.MissingMethodException HResult=0x80131513 Message=Method not found: 'Void Swashbuckle.AspNetCore.SwaggerGen.SchemaRepository..ctor()'. Source=MMLib.SwaggerForOcelot StackTrace: at MMLib.SwaggerForOcelot.Aggregates.AggregateRouteDocumentationGenerator..ctor(IOptions1 routes, IRoutesDocumentationProvider routesDocumentationProvider, IDefinedAggregatorProvider definedAggregatorProvider, Action4 postProcess, ISchemaGenerator schemaGenerator) at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)

However, it looks like the project maintainers have realised this and are fixing it in 6.0.2: https://github.com/domaindrivendev/Swashbuckle.AspNetCore/commit/4331154ab9c4ff58da8cf7ff5f666d59fcd8c855

Do you want me to raise this as another issue or ignore it as it appears to be something that's going to go away of it's own accourd in Swashbuckly 6.0.2?