Burgyn / MMLib.SwaggerForOcelot

This repo contains swagger extension for ocelot.
MIT License
352 stars 94 forks source link

config.AddOcelotWithSwaggerSupport reloadOnChange files #234

Closed naji-makhoul closed 2 years ago

naji-makhoul commented 2 years ago

reloadOnChange file when use AddOcelotWithSwaggerSupport

config.AddOcelotWithSwaggerSupport((o) => {
                  o.Folder = "OcelotConfiguration";                   
            }).AddEnvironmentVariables();

like when add json file :

config.AddJsonFile($"ocelot.{hostingContext.HostingEnvironment.EnvironmentName}.json", optional: false, reloadOnChange: true)
                       .AddEnvironmentVariables();
Burgyn commented 2 years ago

Hi, thank you for your issue.

Unfortunately, you didn't write much. I cannot judge whether it is a question, a comment, a request, ...

Could you please be more specific? Try to describe current behavior, expected behavior, ... Ideally, add an example.

naji-makhoul commented 2 years ago

Hi . i need to reload ocelot file when the file is changes on runtime without restart the app

when i set the ocelot config files with AddOcelotWithSwaggerSupport and change the routes in the file its not updated on runtime

when i use AddJsonFile with reloadOnChange = true , its updated

Burgyn commented 2 years ago

Hi,

which version do you use? This was fix in version 5.2.0 (PR #230)

naji-makhoul commented 2 years ago

I use version 4.9.0 , I will update and check it again, thank you

github-actions[bot] commented 2 years ago

Closing after 8 days of waiting for the additional info requested.