implemented a workaround for Conul service discovary support.

Burgyn / MMLib.SwaggerForOcelot

This repo contains swagger extension for ocelot.

MIT License

351 stars 93 forks source link

implemented a workaround for Conul service discovary support. #288

Closed raga70 closed 5 months ago

raga70 commented 6 months ago

implemented a workaround for Conul service discovery. Although the solution in this PR works (please take it as just guidance on how to fix it) , I did have time to get fully familiar with your code base and just aplied a hot fix.

PS: my ide made a bit of a reformatting on the files I touched (sorry for the extra hassle when reviewing ), if you have any questions send me a message

update-docs[bot] commented 6 months ago

Thanks for opening this pull request! If you have implemented new functions, write about them in the readme file.

Burgyn commented 6 months ago

Hi @raga70,

thanks for your PR. I can merge this PR if you:

fix codefactor bot issues
my comment
and revert formatting of touched methods

thanks.

raga70 commented 6 months ago

Hi @Burgyn I committed the changes you requested .

Burgyn commented 5 months ago

Hi @raga70,

unfortunately your changes failed tests.

Please fix tests.

raga70 commented 5 months ago

I added nullability to my ServiceProviderType since the ServiceProviderConfiguration is in fact null when unit testing

Burgyn commented 5 months ago

Thanks. This will be release soon as v8.2.0.