Closed raga70 closed 5 months ago
Thanks for opening this pull request! If you have implemented new functions, write about them in the readme file.
Hi @raga70,
thanks for your PR. I can merge this PR if you:
thanks.
Hi @Burgyn I committed the changes you requested .
Hi @raga70,
unfortunately your changes failed tests.
Please fix tests.
I added nullability to my ServiceProviderType since the ServiceProviderConfiguration is in fact null when unit testing
Thanks. This will be release soon as v8.2.0
.
implemented a workaround for Conul service discovery. Although the solution in this PR works (please take it as just guidance on how to fix it) , I did have time to get fully familiar with your code base and just aplied a hot fix.
PS: my ide made a bit of a reformatting on the files I touched (sorry for the extra hassle when reviewing ), if you have any questions send me a message