BurhanH / TestAutomationCourse-python-ui-project

Python UI project for Test Automation Course
MIT License
7 stars 10 forks source link

Added pylint static code analyzer. #39

Closed BurhanH closed 2 years ago

BurhanH commented 2 years ago

Added pylint static code analyzer. Updated README.md.

github-actions[bot] commented 2 years ago

Unit Test Results

81 tests  ±0   78 :heavy_check_mark: ±0   4m 25s :stopwatch: +23s   1 suites ±0     3 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 32ad0fb5. ± Comparison against base commit e9823d12.

:recycle: This comment has been updated with latest results.

Stan575 commented 2 years ago

@BurhanH after all tests passed pylint check failed with a bunch of complaints, can be merged though what are your thoughts on this?

BurhanH commented 2 years ago

@BurhanH after all tests passed pylint check failed with a bunch of complaints, can be merged though what are your thoughts on this?

It's up to you guys if you will fix all possible complaints of pylint we can merge it as a fast flow or we can create a second pipeline to validate code standards. In that case, we will have 2 pipelines: one will run our tests, and another one will check code standards. any thoughts @Stan575 ?

Stan575 commented 2 years ago

@BurhanH after all tests passed pylint check failed with a bunch of complaints, can be merged though what are your thoughts on this?

It's up to you guys if you will fix all possible complaints of pylint we can merge it as a fast flow or we can create a second pipeline to validate code standards. In that case, we will have 2 pipelines: one will run our tests, and another one will check code standards. any thoughts @Stan575 ?

I'd go with 2 pipelines. At the moment there's too many pylint complaints

BurhanH commented 2 years ago

Let me rearrange this PR with the second workflow

BurhanH commented 2 years ago

Please review @Stan575