search

Buried-In-Code / Dex-Starr

Dex-Starr helps sort and organize your comic collection by using the information stored in ComicInfo files
GNU General Public License v3.0
0 stars 2 forks source link

Use Mokkari to talk to Metron #10

Closed bpepple closed 3 years ago

bpepple commented 3 years ago

Was doing my weekly review of Metron's server logs, and notices that you were hitting Metron numerous time for the same data (primarily Publish & Series queries). I wrote a python wrapper to Metron Api, Mokkari, that has basic caching and as an added bonus should simplify you code a bit.

You may want modify the code to regenerate the cache db periodically, though really most of the data once it's added to Metron doesn't change often, so that might not be necessary depends on your user-case.

Also, added some initial tests to verify the handling of the parsing code hasn't change.

Any questions, don't hesitate to contact me.

Buried-In-Code commented 3 years ago

Incredible work, thank you. Gives me some ideas for cleanup my messy code in other areas. Things like cache and testing were on my roadmap but hadn't taken a look at getting it implemented yet, this is a great start thanks