Update gulp tasks - Githubissues

BurkusCat / r6-operator-counters

A website with a graph visualisation of how operators counter each other in Rainbow Six Siege.

https://r6counters.com

MIT License

71 stars 38 forks source link

Update gulp tasks #116

Open BurkusCat opened 5 years ago

BurkusCat commented 5 years ago

Gulp tasks no longer live reload properly, need to re-add it back in whilst keeping build non-live reload
Scripts gulp task needs to not minify on gulp default and minify in gulp build

abu271 commented 5 years ago

Hey Burkus,

Can I work on this issue?

bloodywine commented 5 years ago

Hi Abu,

Feel free to work on this issue.

abu271 commented 5 years ago

Hi @BurkusCat @CrayCrayDecay ,

I think I solved the issue the app works fine, so I didn't break anything. I just made minor adjustments to the gulp files.

Thanks,

Abu

anton-dealmeida commented 5 years ago

Is this still open?

BurkusCat commented 5 years ago

Yes it is still open, a PR was raised and merged for this but then reverted because it caused a bug on the deployed site: https://github.com/BurkusCat/r6-operator-counters/pull/126

An issue was raised for a bug it caused https://github.com/BurkusCat/r6-operator-counters/issues/127

If you are interested in this issue, you may want to use the original PR as a reference but make sure the output of "gulp build" works as intended (that is what www.r6counters.com uses)