Closed Mr-Martinez closed 4 years ago
This is fantastic! Thank you so much for working on this. This will make contributing to the repository so much easier for new people.
I won't be able to properly review this PR until the weekend but I will do an initial review now.
I followed your recommendations, replaced public var => private vars in the factory class to keep accidental changes to new operator internal info after creation.
Fixed an issue where the nokk image was not showing. Created a separate js file to hold image paths.
Ready to be reviewed.
Feel free to add your name or username to the humans.txt
and a couple of social media links btw. I've also made you a contributor on this GitHub repo, so you will be able to create future branches on this repo without needing to fork the repo!
I'm curious, was it out of date on your laptop? My npm: v6.13.4 My node: v12.16.1
I added a console.log success message so people will know if the json was created. You don't have to delete the json folder. You can if you want to see if it is working, but if you see the success message on the console, then it means the script ran and overwrote the folder.
Looks good! Great work on this, thank you for contributing :)
Fixes #155
Proposed Changes
Making new operators: