search

BurnP3 / BurnP3Plus

A SyncroSim package to explore fire risk and susceptibility across a landscape.
https://burnp3.github.io/BurnP3Plus/
MIT License
7 stars 4 forks source link

Fix burning hours distribution #40

Closed katieb1 closed 6 months ago

katieb1 commented 6 months ago

Fixed bug where if user sets the total hours burning per day for just "All", but there are more seasons in the project-scoped season table, then a cryptic error is thrown. The new functionality checks if a daily burning hours value is set for "All", then also apply that value for all other seasons that do not have a value provided.

katieb1 commented 6 months ago

Still need to handle case where "All" is not provided and only one of multiple seasons is provided

BadgerOnABike commented 6 months ago

Still need to handle case where "All" is not provided and only one of multiple seasons is provided

Good catch!

katieb1 commented 6 months ago

@BadgerOnABike does this look ok to merge and create a new release?

As a side note - I feel like these cases are especially why unit testing is so important! Maybe we can discuss prioritizing unit tests at our next meeting.