search

BurnP3 / BurnP3Plus

A SyncroSim package to explore fire risk and susceptibility across a landscape.
https://burnp3.github.io/BurnP3Plus/
MIT License
7 stars 4 forks source link

[Burn-P3+ Bug]: Season is mandatory in some but not all datasheets #50

Open shreeramsenthi opened 3 weeks ago

shreeramsenthi commented 3 weeks ago

Contact Details

No response

What happened?

Season is now a mandatory to field for Daily Burning Hours sheet (with the default "All" season) to remove ambiguity, but is still optional in many (all?) other datasheets, which still leads to similar issues that are just harder to catch.

Maybe we should make it mandatory everywhere?

More specifically, this is is in all the advanced ignition datasheets as well as the spread event days and daily weather datasheets.

What component are you seeing the problem on?

Syncrosim

Relevant log output

No response

Approvals Process

BadgerOnABike commented 3 weeks ago

Seems reasonably as this would ensure the column always exists, even if its in an "all" state which is arguably either all or na, as it were.

katieb1 commented 3 weeks ago

I've been working on fixing this, but it's not a super "small" fix. This will require a DB update (so a minor version change) and then will also affect how the input datasheets with the new mandatory column are filtered in all scripts and how the output datasheets are written. I'm thinking we wait until after the BP3+ course to implement? @LeonardoFrid

shreeramsenthi commented 3 weeks ago

makes sense to me! Also, bug was probably not the right label, just wanted to make sure this wasn't an accident.

LeonardoFrid commented 2 weeks ago

agreed on waiting till after the course for implementation.