BurningFlipside / VolunteerSystem

The Flipside Volunteer System
Apache License 2.0
6 stars 2 forks source link

Shifts disappearing from shift set after creation. #123

Closed monikersupreme closed 2 years ago

monikersupreme commented 2 years ago

Created a "Tues TEST Shift" (5/24 from 11:30AM to 6PM) containing 8 total individual shifts (Shift Lead, Cashier x2, Slinger x2, Pusher x2, Camp Contact) and, after the shift had been created, disabled the shift (marked un-enabled).

Returned to Add/Edit Shifts to find the shift had been downsized to 3 positions (Cashier, Slinger, Pusher).

I was able to reproduce this a second time by creating a shift SET with multiples of the same position (11 total this time, Shift Lead, Camp Contact, 3x of Cashier, Slinger, Pusher each) and following the same procedure as above (editing the shift after creation by un-enabling) and again the system seemed to downsize each position by a single shift - leaving me with a set containing only 2x Cashier, Slinger, Pusher (Shift Lead and Camp Contact have been removed)

This behavior isn't completely consistent but seems to be triggered either by multiples of the same role in a shift set and/or a shift being edited after creation.

monikersupreme commented 2 years ago

I think this may be related to the issue Catherine Reynolds reported a few days ago:

'Catherine Reynolds' via Leads | 'Catherine Reynolds' via Leads | Mar 26, 2022, 1:51 PM

and may be the cause of the shifts she lost as well.

monikersupreme commented 2 years ago

Also seeing an error message whenever I attempt to edit a shift set:

image

monikersupreme commented 2 years ago

Steps to reproduce:

Set up a shift set with multiple shifts for each role:

image

Open the shift for edit - I've been toggling the Enabled check box each time but I've actually got this to reproduce without making any changes at all - then select "Save Shift Set":

image

Doing this same procedure multiple times can sometimes result in the shift set getting deleted altogether.

pboyd04 commented 2 years ago

Fixed