search

BurningFlipside / VolunteerSystem

The Flipside Volunteer System
Apache License 2.0
5 stars 2 forks source link

Individual shifts in set appear as taken even though the shift is empty. #132

Closed monikersupreme closed 2 years ago

monikersupreme commented 2 years ago

I've checked on a couple different browsers just in case there was some sort of caching issue but it's showing up on both.

From my admin view:

Tues TEST Shift-7 on the calendar: image

Tues TEST Shift-7 in Add/Edit Shifts: image

pboyd04 commented 2 years ago

There is a pending group signup for that shift (i.e. you didn't abandon that signup for the entire group). This is expected behavior. "status": "groupPending",

monikersupreme commented 2 years ago

I don't see any pending signups for that shift from my admin view (assuming this is where the groupPending status should show)...

image

After deleting the group signup link "Tues TEST Shift-7" is still showing as partially filled. If I create a new link the shift now shows as completely filled, however, subsequently deleting this link does not empty the shift set (still shows as completely filled).

If I assign a role in the shift set (ex Camp Contact) then empty that role, the individual shift in the set now appears empty on the schedule but the rest of the set is still filled.

image

I think what's happening is that the groupPending status is not being abandoned when the link itself is removed from the shift. I'd assume that, if this link is abandoned, any individual shift/role that is not currently pending should be marked as empty.

pboyd04 commented 2 years ago

groupPending means it is waiting for someone to signup for a group shift. That doesn't show up in the pending report.