search

BurntSushi / byteorder

Rust library for reading/writing numbers in big-endian and little-endian.
The Unlicense
981 stars 143 forks source link

u128 is stable #136

Closed WildCryptoFox closed 5 years ago

WildCryptoFox commented 5 years ago

https://doc.rust-lang.org/stable/std/primitive.u128.html

https://github.com/BurntSushi/byteorder/blob/master/Cargo.toml#L26

BurntSushi commented 5 years ago

This isn't an actionable ticket. I don't know what you're asking me to do. Please consider being more explicit about the problem you're trying to solve.

WildCryptoFox commented 5 years ago

@BurntSushi Sorry. The feature is unnecessary and may be removed as stable rust supports it.

BurntSushi commented 5 years ago

@james-darkfox No, it can't. Firstly, the feature needs to remain for backwards compatibility. Secondly, byteorder maintains a minimum supported Rust version of 1.12. Given how widely used byteorder is, I'd prefer not to change that.

One thing we could do is version sniff the rustc version and enable u128 APIs if the rustc version supports it.

Are you filing this issue because there is an actual problem with the current setup?

WildCryptoFox commented 5 years ago

@BurntSushi Okay, fair reason. No actual problem, just didn't realize the minimum supported version and thought it was unnecessary. My bad, I target nightly and just smile when my code runs on stable. ;)

Thanks for the quick response.