search

BurntSushi / memchr

Optimized string search routines for Rust.
The Unlicense
899 stars 102 forks source link

Runtime customization of byte-frequency table #118

Closed sentrip closed 1 year ago

sentrip commented 1 year ago

Ah, in the docs I renamed Heuristicx86 to x86 and didn't run tests again. I fixed it, but I guess that can be combined into the commit that renames the trait/method

BurntSushi commented 1 year ago

Yeah when you make changes, for a small PR like this, just keep everything in one commit. You can force push.

BurntSushi commented 1 year ago

Hmmm can you submit another PR with the default type parameter approach? I think I'd still prefer that route if it can be made to work. Just wanted to look at it and play with it myself.

sentrip commented 1 year ago

Yes I will upload it now, and thanks for the tip!

sentrip commented 1 year ago

All the checks seem to pass, all that is left here is the names. My favorites are RareBytes/build_with_ranker, but I will wait for you to check the implementations out. If you like this one then let me know what to change the names to.