search

BurntSushi / nflgame

An API to retrieve and read NFL Game Center JSON data. It can work with real-time data, which can be used for fantasy football.
http://pdoc.burntsushi.net/nflgame
The Unlicense
1.27k stars 412 forks source link

Not able to pull 2018 pre-season stats #366

Open joaoleite98 opened 5 years ago

joaoleite98 commented 5 years ago

How to update schedule so that it includes 2018 games?

Shouldn't nflgame.update_sched.run() work?

ochawkeye commented 5 years ago

NFL.com is telling us that it is still 2017.

See #363 for workaround.

jrh23 commented 5 years ago

Yeah - I'm having the same issues myself!

ochawkeye commented 5 years ago

Please try the steps noted in https://github.com/BurntSushi/nflgame/issues/363#issuecomment-409084354 and let me know if you are still having problems.

jrh23 commented 5 years ago

I have been using the live function to output games of the week to a LED sign I made. It seems this function isn't corrected by the solution you mentioned. I appreciate the help though

ochawkeye commented 5 years ago

I'm still not following what's not working...

S:\>python
Python 2.7.14 (v2.7.14:84471935ed, Sep 16 2017, 20:19:30) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import nflgame
>>> games = nflgame.games(2018, kind='PRE', week=2)
>>> for game in games:
...     print game
...
NYJ (13) at WAS (15)
PIT (34) at GB (51)
PHI (20) at NE (37)
KC (28) at ATL (14)
MIA (20) at CAR (27)
BUF (19) at CLE (17)
NYG (30) at DET (17)
ARI (20) at NO (15)
CIN (21) at DAL (13)
CHI (24) at DEN (23)
SF (13) at HOU (16)
SEA (14) at LAC (24)
OAK (15) at LA (19)
JAX (14) at MIN (10)
TB (30) at TEN (14)
>>>
derek-adair commented 5 years ago

Hello, we have a forked version of this project setup here. You are welcome to try out our new alpha release which includes some fixes to get nflgame. Including some usability fixes which should help with this exact issue.

pip install nflgame-redux==1.2.22a2

ahadden09 commented 5 years ago

Does nfldb work with the forked version?

derek-adair commented 5 years ago

I have not tested this but nflgame-redux should be a drop in replacement in nfldb. maybe @ochawkeye can speak to this.

However, you should have no problems but will need to manually install the nflgame-redux repository somehow. Easiest would probably be forking and changing setup.py to reference nflgame-redux.

I am considering forking all of the nfl* code but I am undecided and need to reach out ot more contributors across the projects.

ochawkeye commented 5 years ago

Yes, this fork of nflgame works with nfldb. Whether intentional or not, pip install nflgame-redux actually replaces/overwrites the nflgame package installed in ..\PATH\TO\PYTHON\Lib\site-packages (it installs in \nflgame not in \nflgame-redux)

S:\>python
Python 2.7.14 (v2.7.14:84471935ed, Sep 16 2017, 20:19:30) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import nfldb
>>> db = nfldb.connect()
>>> q = nfldb.Query(db)
>>> q.game(season_year=2018, season_type='Preseason')
<nfldb.query.Query object at 0x020E4410>
>>> for game in q.as_games():
...     print game
>>>
Preseason 2018 week 2 on 08/20 at 07:00PM, BAL (20) at IND (19)
Preseason 2018 week 2 on 08/18 at 07:00PM, TB (30) at TEN (14)
Preseason 2018 week 2 on 08/18 at 12:00PM, JAC (14) at MIN (10)
Preseason 2018 week 2 on 08/18 at 03:00PM, OAK (15) at LA (19)
Preseason 2018 week 2 on 08/18 at 09:00PM, SEA (14) at UNK (24)
Preseason 2018 week 2 on 08/18 at 07:00PM, SF (13) at HOU (16)
Preseason 2018 week 2 on 08/18 at 08:05PM, CHI (24) at DEN (23)
Preseason 2018 week 2 on 08/18 at 06:00PM, CIN (21) at DAL (13)
Preseason 2018 week 2 on 08/17 at 07:00PM, ARI (20) at NO (15)
Preseason 2018 week 2 on 08/17 at 06:00PM, NYG (30) at DET (17)
Preseason 2018 week 2 on 08/17 at 06:30PM, BUF (19) at CLE (17)
Preseason 2018 week 2 on 08/17 at 06:30PM, MIA (20) at CAR (27)
Preseason 2018 week 2 on 08/17 at 06:00PM, KC (28) at ATL (14)
Preseason 2018 week 2 on 08/16 at 06:30PM, PHI (20) at NE (37)
Preseason 2018 week 2 on 08/16 at 07:00PM, PIT (34) at GB (51)
Preseason 2018 week 2 on 08/16 at 07:00PM, NYJ (13) at WAS (15)
Preseason 2018 week 1 on 08/11 at 08:00PM, MIN (42) at DEN (28)
Preseason 2018 week 1 on 08/11 at 09:00PM, UNK (17) at ARI (24)
Preseason 2018 week 1 on 08/10 at 09:30PM, DET (10) at OAK (16)
Preseason 2018 week 1 on 08/10 at 06:30PM, ATL (0) at NYJ (17)
Preseason 2018 week 1 on 08/09 at 09:00PM, IND (19) at SEA (17)
Preseason 2018 week 1 on 08/09 at 09:00PM, DAL (21) at SF (24)
Preseason 2018 week 1 on 08/09 at 06:00PM, PIT (31) at PHI (14)
Preseason 2018 week 1 on 08/09 at 06:00PM, CLE (20) at NYG (10)
Preseason 2018 week 1 on 08/09 at 06:30PM, WAS (17) at NE (26)
Preseason 2018 week 1 on 08/09 at 06:00PM, TB (26) at MIA (24)
Preseason 2018 week 1 on 08/09 at 07:30PM, HOU (17) at KC (10)
Preseason 2018 week 1 on 08/09 at 06:00PM, NO (24) at JAC (20)
Preseason 2018 week 1 on 08/09 at 07:00PM, TEN (17) at GB (31)
Preseason 2018 week 1 on 08/09 at 06:00PM, CHI (27) at CIN (30)
Preseason 2018 week 1 on 08/09 at 06:00PM, CAR (28) at BUF (23)
Preseason 2018 week 1 on 08/09 at 06:30PM, LA (7) at BAL (33)
Preseason 2018 week 0 on 08/02 at 07:00PM, CHI (16) at BAL (17)
Preseason 2018 week 4 on 08/30 at 07:00PM, MIN (0) at TEN (0)
Preseason 2018 week 4 on 08/30 at 06:30PM, JAC (0) at TB (0)
Preseason 2018 week 4 on 08/30 at 09:00PM, OAK (0) at SEA (0)
Preseason 2018 week 4 on 08/30 at 09:00PM, UNK (0) at SF (0)
Preseason 2018 week 4 on 08/30 at 06:30PM, CAR (0) at PIT (0)
Preseason 2018 week 4 on 08/30 at 06:00PM, NYJ (0) at PHI (0)
Preseason 2018 week 4 on 08/30 at 06:00PM, NE (0) at NYG (0)
Preseason 2018 week 4 on 08/30 at 07:00PM, LA (0) at NO (0)
Preseason 2018 week 4 on 08/30 at 07:30PM, GB (0) at KC (0)
Preseason 2018 week 4 on 08/30 at 07:00PM, DAL (0) at HOU (0)
Preseason 2018 week 4 on 08/30 at 06:00PM, CLE (0) at DET (0)
Preseason 2018 week 4 on 08/30 at 06:00PM, IND (0) at CIN (0)
Preseason 2018 week 4 on 08/30 at 07:00PM, BUF (0) at CHI (0)
Preseason 2018 week 4 on 08/30 at 06:30PM, WAS (0) at BAL (0)
Preseason 2018 week 4 on 08/30 at 06:00PM, MIA (0) at ATL (0)
Preseason 2018 week 4 on 08/30 at 09:00PM, DEN (0) at ARI (0)
Preseason 2018 week 3 on 08/26 at 07:00PM, ARI (0) at DAL (0)
Preseason 2018 week 3 on 08/26 at 03:00PM, CIN (0) at BUF (0)
Preseason 2018 week 3 on 08/25 at 07:00PM, NO (0) at UNK (0)
Preseason 2018 week 3 on 08/25 at 03:00PM, TEN (0) at PIT (0)
Preseason 2018 week 3 on 08/25 at 06:00PM, BAL (0) at MIA (0)
Preseason 2018 week 3 on 08/25 at 03:00PM, HOU (0) at LA (0)
Preseason 2018 week 3 on 08/25 at 06:00PM, ATL (0) at JAC (0)
Preseason 2018 week 3 on 08/25 at 03:30PM, SF (0) at IND (0)
Preseason 2018 week 3 on 08/25 at 12:00PM, KC (0) at CHI (0)
Preseason 2018 week 3 on 08/24 at 07:00PM, DET (0) at TB (0)
Preseason 2018 week 3 on 08/24 at 06:30PM, DEN (0) at WAS (0)
Preseason 2018 week 3 on 08/24 at 09:30PM, GB (0) at OAK (0)
Preseason 2018 week 3 on 08/24 at 06:30PM, NYG (0) at NYJ (0)
Preseason 2018 week 3 on 08/24 at 07:00PM, SEA (0) at MIN (0)
Preseason 2018 week 3 on 08/24 at 06:30PM, NE (0) at CAR (0)
Preseason 2018 week 3 on 08/23 at 07:00PM, PHI (0) at CLE (0)
derek-adair commented 5 years ago

@ochawkeye - This was SEMI intentional (as the project ocupies the same namespace).... however I've not tested how pip resolves requirements like this extensively.

Does it matter what order you install them in?

ochawkeye commented 5 years ago

The two cannot coexist.

pip didn't make any effort to resolve the conflict in names. Every file in the \site-packages\nflgame directory was replaced with its counterpart in the nflgame-redux package.

Does it matter what order you install them in?

If one were to pip install nflgame-redux and then later pip install nflgame your code would be wiped out by whatever PyPi has sitting out there in nflgame.

In my mind I would have import nflgame-redux as nflgame vs import nflgame to test the same code but that ship has sailed. My previous install of nflgame was replaced by this forked version.

Probably not a huge deal since this fork serves as the normal evolution of the old nflgame, but does strike me as a big pip issue. Say I released to PyPi a packaged called totally-NOT-urllib3-I-promise but inside it called it urllib3. pip install totally-NOT-urllib3-I-promise would nuke my real urllib3 library really without any sort of warning.

derek-adair commented 5 years ago

Ehhh I, not so passionately, disagree with import nflgame-redux as nflgame. Keeping the same namespace is something i've seen other revival forks do when it is intends to pick up a dead or dying project and, for me personally, is 100% desired.

In an ideal situation we gain enough traction for the fork to get acknlowedged and replace the entire pypi listing and existing repository to us. Or some version of events similar to that.

derek-adair commented 5 years ago

Also this needs to be clearly documented to avoid the situation I put you in.