Open Spoonbender opened 3 years ago
Perhaps quickcheck should also exclude support for these types when targeting emscripten?
If doing so is simple, easy to maintain and testable in CI, then sure. A PR is welcome.
@BurntSushi great, I'll try to tackle this
@BurntSushi after taking an initial stab at this, I see there are multiple, distinct issues to resolve. I will open separate bugs and PRs for each as each could be accepted or rejected individually, and each provides value by itself. I'll rename this bug to add support for wasm32-unknown-emscripten
target.
I'm unable to build
quickcheck
when targeting thewasm32-unknown-emscripten
build target. Please consider adding support for wasm as a 1st class citizen!Repro: Using
master
atdefde6fb0ce20b0c8c4e672aa9ae821f7d1f5b38
, Perform the following steps:rustup target add wasm32-unknown-emscripten
quickcheck
for this target usingcargo build --target wasm32-unknown-emscripten
Expected result:
quickcheck
is successfully built for the wasm targetActual result: Compilation fails with the following message:
Notes:
rand
disabled support fori128
andu128
when targeting emscripten, due to emscripten limitations (see: https://github.com/rust-random/rand/pull/671 ). Perhapsquickcheck
should also exclude support for these types when targeting emscripten?