search

BurntSushi / quickcheck

Automated property based testing for Rust (with shrinking).
The Unlicense
2.4k stars 149 forks source link

Only build debug representations of arguments on failing tests #304

Open davidrusu opened 2 years ago

davidrusu commented 2 years ago

fixes #303

This cuts my prop test run-times nearly in half!

Here's the new flamegraph showing nearly 70% of time spent in test, previously this was 40%.

image compare to prior run: image

davidrusu commented 2 years ago

@BurntSushi this change nets us a 50% reduction in quickcheck's overhead

It's a fairly small change, so hopefully quick to review. I'd love to see it merged in soon.

neithernut commented 2 years ago

There are bug-fixes pending for months. I wouldn't get my hopes up.

dan-da commented 2 years ago

+1 for getting this merged asap. else I'll need to start referencing @davidrusu's fork in our crates instead.

niyaznigmatullin commented 2 years ago

+1 is there anyone who wants to maintain this crate, probably we ask @BurntSushi to give rights or just use some other fork, @davidrusu's for instance, to continue developing this. The same is with crates.io, we could just create another crate