search

BurntSushi / ripgrep

ripgrep recursively searches directories for a regex pattern while respecting your gitignore
The Unlicense
47.94k stars 1.97k forks source link

add Makefile.inc to "make" type #2846

Open bad opened 3 months ago

bad commented 3 months ago

The *BSD build systems make use of "Makefile.inc" a lot. Make the "make" type recognize this file by default.

okdana commented 3 months ago

You might consider generalising this to Makefile.* actually. It's common to use this naming convention for alternate Makefiles, e.g. for different targets. An extreme example of this is RetroArch, but even FreeBSD has some other instances that the change in its current form wouldn't address

(If you did do it that way, i would suggest Makefile.* instead of [Mm]akefile.* because the latter seems too prone to false positives in this case)

bad commented 2 months ago

Is there a reason this PR hasn't been merged yet?

BurntSushi commented 2 months ago

Sometimes it just takes me a while.

Otherwise I think I agree with @okdana's feedback here.

bad commented 2 months ago

Thanks for the quick response.

I'm fine with @okdana's suggestion and changed the code.