fix the mistake of overriding mode

BurntSushi / ripgrep

ripgrep recursively searches directories for a regex pattern while respecting your gitignore

The Unlicense

48.92k stars 2.01k forks source link

fix the mistake of overriding mode #2880

Open QWZeng opened 2 months ago

QWZeng commented 2 months ago

a non-searching mode can override non-searching mode. It’s likely just a mistake or typo : if !matches!(*self, Mode::Search()); it should be： if !matches!(new, Mode::Search())

BurntSushi commented 2 months ago

I think the docs are wrong here.

Also, why are you opening multiple PRs? I see this one and #2879.

QWZeng commented 2 months ago

I think the docs are wrong here.

Also, why are you opening multiple PRs? I see this one and #2879.

I think the docs are wrong here.

Also, why are you opening multiple PRs? I see this one and #2879.

Excuse me, I'm not sure what did you mean "the docs wrong here", the comments are wrong in code? I've closed the #2879 PR, sorry for that.